Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xdrill for ledgerCloseMeta #5568

Merged
merged 14 commits into from
Jan 21, 2025
Merged

Conversation

chowbao
Copy link
Contributor

@chowbao chowbao commented Jan 8, 2025

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've reviewed the changes in this PR and if I consider them worthwhile for being mentioned on release notes then I have updated the relevant CHANGELOG.md within the component folder structure. For example, if I changed horizon, then I updated (services/horizon/CHANGELOG.md. I add a new line item describing the change and reference to this PR. If I don't update a CHANGELOG, I acknowledge this PR's change may not be mentioned in future release notes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

github issue

xdrill functions for LedgerCloseMeta

Why

First commit for xdrill with the low level helper functions from the processors/transforms from stellar-etl for history_ledgers found here

Known limitations

  • Refactor of the processor/transforms to be done in separate ticket/pr

exp/xdrill/ledger_test.go Outdated Show resolved Hide resolved
exp/xdrill/ledger.go Outdated Show resolved Hide resolved
exp/xdrill/utils/utils.go Outdated Show resolved Hide resolved
exp/xdrill/utils/utils.go Outdated Show resolved Hide resolved
exp/xdrill/utils/utils.go Outdated Show resolved Hide resolved
Copy link

@sydneynotthecity sydneynotthecity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks like a good start, just had a couple comments about consistency within the package to ensure that we're not carrying over oddities from stellar-etl that we should fix now.

ingest/ledger/ledger.go Outdated Show resolved Hide resolved
xdr/node_id.go Outdated Show resolved Hide resolved
ingest/ledger/ledger.go Outdated Show resolved Hide resolved
xdr/ledger_close_meta.go Outdated Show resolved Hide resolved
ingest/ledger/ledger.go Outdated Show resolved Hide resolved
ingest/ledger/ledger.go Outdated Show resolved Hide resolved
@chowbao chowbao mentioned this pull request Jan 17, 2025
7 tasks
Copy link
Contributor

@tamirms tamirms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

Copy link

@sydneynotthecity sydneynotthecity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chowbao chowbao merged commit 07d197a into stellar:master Jan 21, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants